Skip to content

doc: Describe issue triaging #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2020
Merged

doc: Describe issue triaging #2416

merged 2 commits into from
Dec 8, 2020

Conversation

@nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Dec 7, 2020

No description provided.

@nhooyr nhooyr requested review from code-asher, jsjoeio and oxy December 7, 2020 20:18
jsjoeio
jsjoeio approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good-to-me-this-looks

code-asher
code-asher approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope.

oxy
oxy approved these changes Dec 7, 2020
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 7, 2020

Elaborated further, would appreciate your review @oxy

@nhooyr nhooyr requested a review from oxy December 7, 2020 21:48
@nhooyr nhooyr force-pushed the issue-036f branch 2 times, most recently from 5d253cf to 2b204f4 Compare December 7, 2020 22:17
oxy
oxy approved these changes Dec 8, 2020
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nhooyr nhooyr merged commit 225583b into master Dec 8, 2020
@nhooyr nhooyr deleted the issue-036f branch December 8, 2020 15:01
@nhooyr nhooyr added this to the v3.8.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher code-asher approved these changes

+2 more reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@oxy oxy oxy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nhooyr @jsjoeio @oxy @code-asher